fix StringNormalizer test failures for onnxruntime backend #19
Merged
prasanthpul merged 1 commit intoonnx:masterfrom Apr 13, 2020
Merged
fix StringNormalizer test failures for onnxruntime backend #19prasanthpul merged 1 commit intoonnx:masterfrom
prasanthpul merged 1 commit intoonnx:masterfrom
Conversation
pranavsharma
approved these changes
Apr 13, 2020
This was referenced May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 12 test failures for onnxruntime backend related to StringNormalizer.
The errors show
E onnxruntime.capi.onnxruntime_pybind11_state.RuntimeException: [ONNXRuntimeError] : 6 : RUNTIME_EXCEPTION : Exception during initialization: /onnxruntime_src/onnxruntime/core/pro
viders/cpu/nn/string_normalizer.cc:87 onnxruntime::string_normalizer::Locale::Locale(const string&) Failed to construct locale with name:en_US.UTF-8:locale::facet::_S_create_c_locale na
me not valid:Please, install necessary language-pack-XX and configure locales
The root cause is the docker image doesn't install and configure locales per onnxruntime README.md
This PR adds the necessary locales installation and configuration. The previously failing tests pass after applying this fix.