Skip to content

add fixup and python3Packages.duckdb to NixOS#444225#1

Closed
cameronraysmith wants to merge 0 commit intoonnimonni:update-duckdb-1.4from
cameronraysmith:update-duckdb-1.4
Closed

add fixup and python3Packages.duckdb to NixOS#444225#1
cameronraysmith wants to merge 0 commit intoonnimonni:update-duckdb-1.4from
cameronraysmith:update-duckdb-1.4

Conversation

@cameronraysmith
Copy link
Collaborator

@cameronraysmith cameronraysmith commented Sep 24, 2025

Fast-forwarding NixOS#444225 (i.e. manual git cli-based git merge --ff-only and git push but NOT PR merge from github ui which does not allow fast-forward merging and therefore overwrites the commit hashes ) by the changes in this PR will apply

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@cameronraysmith cameronraysmith marked this pull request as ready for review September 24, 2025 04:07
@cameronraysmith cameronraysmith changed the title add fixup and python3Packages.duckdb to nixos/nixpkgs#444225 add fixup and python3Packages.duckdb to NixOS#444225 Sep 24, 2025
@cameronraysmith
Copy link
Collaborator Author

cameronraysmith commented Sep 24, 2025

nixpkgs CI and nixpkgs-review build succeeded for duckdb and python3Packages.duckdb
NixOS#444982 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant