Merge modernization PR from the master and replace notion-react-x dependency with my fork#2
Merged
Merged
Conversation
…ation-with-fixes * commit '2ed08bf7856f569c0617e36e6b14a59e4bddbc71': fix(search): fix search error not being passed to NotionRenderer properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Original author of this template doesn't seem to have much time to maintain his excellent starter.
There were multiple fixes merged to the main dependency https://github.com/NotionX/react-notion-x but nobody created releases from them.
I forked the
react-notion-xand published the included smaller packages to npmjs.com.If one wants to use them they need to update their
tsconfig.jsonandnext.config.jsto automatically replace the packages with my forks.I'm using this starter in multiple sites and thus am invested in maintaining it for now but I will not give any promises and I will merge opinionated features suitable for my use case into the
mainbranch.