-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: update parser exports #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Caution Review failedThe pull request is closed. WalkthroughBroad refactor separates type-only and runtime imports across many modules, renames parser exports (t/T) in packages.ts, and updates dependent imports. A Next.js project import context gains stricter validation, expanded Project shape, additional state fields, and refined finalize/upload flow. Minor signature tweaks remove explicit types from defaulted params. ESLint rule adjusted. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as Import UI
participant Ctx as ProjectCreationContext
participant FS as Code Provider
participant NX as Next.js Detector
User->>UI: Select local project
UI->>Ctx: initialize(projectPath, files)
Ctx->>NX: validateNextJsProject(package.json, files)
NX-->>Ctx: {routerType, deps, layoutInfo}
Ctx->>Ctx: setState({direction, isFinalizing=false})
Ctx->>FS: writeFile(uploaded layout/scripts)
FS-->>Ctx: ack
Ctx->>Ctx: finalizeProject()
Ctx-->>UI: done or error
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (37)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Update import statements to use inline type imports across the codebase, enhancing consistency and aligning with TypeScript best practices.
index.tsx,font-config-manager.ts, andfont-upload-manager.ts.packages/fonts/src/helpers,packages/parser/src, andtooling/eslint/base.js.base.jsto enforce inline type imports usingimport/consistent-type-specifier-stylerule.This description was created by
for 5633366. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit