-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Revert "fix: some gpt-5 stutter" #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 740ec31.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Caution Review failedThe pull request is closed. WalkthroughUpdates downgrade AI SDK dependencies, refactor chat message rendering to use UI context with per-role components, remove the old MessageList, adjust message content styling/props, introduce introspection-aware streaming states, and change tool-call flow to await results and return values directly via a revised async handleToolCall. Hook integration is updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as Chat UI
participant Hook as use-chat
participant Tools as handleToolCall(...)
participant Engine as EditorEngine
participant Chat as Chat Context
UI->>Hook: onToolCall(toolCall)
Hook->>Tools: await handleToolCall(toolCall, editorEngine)
Tools->>Engine: resolve mode/tools, fetch handler
alt tool available
Tools-->>Hook: result (output)
Hook->>Chat: addToolResult{ tool, toolCallId, output }
else tool missing/error
Tools-->>Hook: error string
Hook->>Chat: addToolResult with error output
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reverts #2836
Important
Reverts dependency versions and restores previous implementations for chat message rendering and tool call handling.
@ai-sdk/reactfrom2.0.44to2.0.25andaifrom5.0.44to5.0.26inpackage.jsonandbun.lock.ChatMessagescomponent logic inindex.tsxto previous implementation.MessageListcomponent inmessage-list.tsx.StreamMessagelogic instream-message.tsx.handleToolCallfunction logic intools.tsto previous implementation.This description was created by
for 2491d5f. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit