-
Notifications
You must be signed in to change notification settings - Fork 28
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
install gtp2ogs and node_modules locally (no global -g), default to d…
…evel, add package-lock.json (#260) * install node locally (not global) - update linux instructions to support ubuntu 20.04: the old install method from node.js's github does not work anymore, using nvm (Node Version Manager) node.js install method now, which supports many node versions and allows to easily backwards use an old node version for testing or compatibility reasons. - install and run node locally (no sudo): now installing gtp2ogs locally in home folder (instead of global -g install). this provides a lot of advantages, including no need to use `sudo` anymore - get gtp2ogs first from github using clone or download ZIP, not with `npm install gtp2ogs`, so there is no need to upgrade to devel anymore as we set up the right branch we want to use from the start - then after gtp2ogs is downloaded, run `npm install` inside gtp2ogs folder: so now now_modules are inside gtp2ogs folder, unlike in the past where it was the opposite. This gives gives several advantages, for example developers can use `git` to easily checkout between branches and test changes - split WINDOWS and LINUX instructions in separate files, to make main README.md lighter, but also so that user can quickly get the desired information about their specific operating system. - removed CONTRIBUTING.md: we don't want to support general github instructions in this specific repo, adds extra maintainance, this would have a better place in an outside repo we can link to - rename "arguments" to options most of the time: an option is an abstract concept. In gtp2ogs, options are specified as command-line arguments, either "gtp2ogs arguments" or "bot arguments" - fixed README.md according to markdownlint's rules - minor other tweaks and fixes * commit package-lock.json this is good practices as @Dorus explained, to keep track of the exact version of each package we are running, to avoid unexpected incompatiblities, as explained in DEV.md * sync current branch with devel + a minor tweak in OPTIONS-LIST * clearer wording
- Loading branch information
1 parent
ac53cb5
commit b6b5be2
Showing
9 changed files
with
2,210 additions
and
339 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.