Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on #167 the GobanSVG onTap tests were flaky due to timeout. The SVG tests usually complete in <50ms, but one onTap test jumps over the 200ms threshold on occasion.
While the SVG tests run noticeably slower than Canvas tests (1-10ms vs 20-50ms on average), I wasn't able to determine whether there is a real perf issue. At any rate, I think it's reasonable to increase the timeout parameter since Jest's default is a whopping 5s.
Test Plan
I stress tested with this command:
10 runs is more than enough to trigger the timeout at 200 ms, but we get no timeouts at the 1s threshold.
Alternative considered
We could alternatively increase timeout on a per-test basis. This would be fine too IMO, just takes more thought about which tests need it.