Add missing id to notification type

online-go · May 2, 2024 · 3992301 · 3992301
1 parent 9e2bab6
commit 3992301
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/protocol/ClientToServer.ts b/src/protocol/ClientToServer.ts
@@ -372,7 +372,7 @@ export interface ClientToServer extends ClientToServerBase {
     }) => number;
 
     /** Deletes a notification */
-    "notification/delete": (data: { notification_id: number }) => void;
+    "notification/delete": (data: { notification_id: string }) => void;
 
     /** Connects to the game list count.
      *  Once connected you'll start receiving `gamelist-count` or

diff --git a/src/protocol/ServerToClient.ts b/src/protocol/ServerToClient.ts
@@ -102,6 +102,8 @@ export interface ServerToClient {
      *  as a reference for what types there are and what data they contain
      */
     "notification": (data: {
+        /** The notification id */
+        id: string;
         /** The notification type */
         type: string;
         /** There are often more fields here */