Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-12991] Upgrade to openRTB 2.6: Fork new repo #1

Merged

Conversation

Araknyfe
Copy link
Collaborator

Changes are mentionned in different releases.
Mostly these are changes that we made on our old fork and that were not in the source repo.

@Araknyfe Araknyfe changed the title Chore/sc 12756/did we change something in the video requests [sc-12991] Upgrade to openRTB 2.6 Mar 21, 2024
Copy link
Collaborator

@GodefroiRoussel GodefroiRoussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to change the Value in the native1/response/data.go, previously we had
Value interface{} json:"value"``

I'm wondering but I haven't verify yet, do we need to change openrtb3/no_bid_reason.go to be an int as it was in our previous version ?

openrtb2/native.go Outdated Show resolved Hide resolved
openrtb2/audio.go Outdated Show resolved Hide resolved
@Araknyfe
Copy link
Collaborator Author

I think we have to change the Value in the native1/response/data.go, previously we had Value interface{} json:"value"``

I'm wondering but I haven't verify yet, do we need to change openrtb3/no_bid_reason.go to be an int as it was in our previous version ?

Yes for Value good catch, as for NoBidReason I don't think so as it used once and cast as an int32 but it's worth checking again :)

@Araknyfe Araknyfe changed the title [sc-12991] Upgrade to openRTB 2.6 [sc-12991] Upgrade to openRTB 2.6: Fork new repo Apr 3, 2024
@Abyfall
Copy link

Abyfall commented Apr 3, 2024

I think we have to change the Value in the native1/response/data.go, previously we had Value interface{} json:"value"``

I'm wondering but I haven't verify yet, do we need to change openrtb3/no_bid_reason.go to be an int as it was in our previous version ?

Do you know why we chose to go from string to interface here ?

@GodefroiRoussel
Copy link
Collaborator

I think we have to change the Value in the native1/response/data.go, previously we had Value interface{} json:"value"``
I'm wondering but I haven't verify yet, do we need to change openrtb3/no_bid_reason.go to be an int as it was in our previous version ?

Do you know why we chose to go from string to interface here ?

When looking at the commit doing this change it is for :

Use interface for retro compatibility with Native 1.0

@Araknyfe Araknyfe merged commit d27db2e into main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants