-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sc-12991] Upgrade to openRTB 2.6: Fork new repo #1
[sc-12991] Upgrade to openRTB 2.6: Fork new repo #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to change the Value in the native1/response/data.go, previously we had
Value interface{}
json:"value"``
I'm wondering but I haven't verify yet, do we need to change openrtb3/no_bid_reason.go to be an int as it was in our previous version ?
Yes for Value good catch, as for NoBidReason I don't think so as it used once and cast as an int32 but it's worth checking again :) |
Do you know why we chose to go from string to interface here ? |
When looking at the commit doing this change it is for :
|
Changes are mentionned in different releases.
Mostly these are changes that we made on our old fork and that were not in the source repo.