Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci linter to 1.63 #6888

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Upgrade golangci linter to 1.63 #6888

merged 2 commits into from
Jan 15, 2025

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Jan 14, 2025

This PR upgrades the golangci-lint action to use version 1.63 (from 1.54), in order to add support for Go versions 1.22+. It addresses a few lint issues added since 1.54 (mainly a new govet rule about format strings).

The linter supports Go versions up to the version used to build the binary. Older linter releases are not re-built when a new Go release comes out.

Context: #6871 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 41.12%. Comparing base (b740fc0) to head (c396112).

Files with missing lines Patch % Lines
engine/access/rpc/backend/backend_transactions.go 0.00% 6 Missing ⚠️
cmd/util/cmd/common/node_info.go 0.00% 5 Missing ⚠️
utils/grpcutils/grpc.go 0.00% 3 Missing ⚠️
engine/common/grpc/forwarder/forwarder.go 0.00% 2 Missing ⚠️
state/protocol/badger/mutator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6888   +/-   ##
=======================================
  Coverage   41.11%   41.12%           
=======================================
  Files        2116     2116           
  Lines      185749   185737   -12     
=======================================
+ Hits        76378    76389   +11     
+ Misses     102954   102936   -18     
+ Partials     6417     6412    -5     
Flag Coverage Δ
unittests 41.12% <5.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanschalm jordanschalm marked this pull request as ready for review January 14, 2025 23:53
@jordanschalm jordanschalm requested a review from a team as a code owner January 14, 2025 23:53
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@jordanschalm jordanschalm added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit 0d2b34f Jan 15, 2025
56 checks passed
@jordanschalm jordanschalm deleted the jord/test-lint-upgrade branch January 15, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants