Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Move tracing reset to OnTxEnd hook #6627

Merged

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Nov 7, 2024

Currently, the gas field was always set to 0x0, due to the tracing reset being done on OnTxStart:

{
      "txHash": "0xf730eacee38a28f93fcf1a9a1f9c360542fe20e3200510126976bb9ee7fd3fca",
      "result": {
        "from": "0x0000000000000000000000030000000000000000",
        "gas": "0x0",
        "gasUsed": "0x5208",
        "to": "0x2c91520ee9e2c55593dc425e1c2b82026391dea7",
        "input": "0x",
        "value": "0x18321634f200",
        "type": "CALL"
      }
    }

@m-Peter m-Peter self-assigned this Nov 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.08%. Comparing base (a764d3e) to head (269053f).

❗ There is a different number of reports uploaded between BASE (a764d3e) and HEAD (269053f). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (a764d3e) HEAD (269053f)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6627       +/-   ##
===========================================
- Coverage   41.23%   29.08%   -12.15%     
===========================================
  Files        2054       29     -2025     
  Lines      182359     1647   -180712     
===========================================
- Hits        75188      479    -74709     
+ Misses     100867     1116    -99751     
+ Partials     6304       52     -6252     
Flag Coverage Δ
unittests 29.08% <ø> (-12.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1010001 j1010001 mentioned this pull request Nov 7, 2024
@j1010001 j1010001 added the Bug Something isn't working label Nov 7, 2024
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@franklywatson franklywatson added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@franklywatson franklywatson added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Nov 14, 2024
Merged via the queue into onflow:master with commit 22daf5c Nov 14, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants