Disable adx in util build #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
requested review from
vishalchangrani,
turbolent,
zhangchiqing and
peterargue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6580 +/- ##
==========================================
+ Coverage 41.09% 41.10% +0.01%
==========================================
Files 2020 2020
Lines 178571 178571
==========================================
+ Hits 73375 73395 +20
+ Misses 99042 99026 -16
+ Partials 6154 6150 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The fix has been successfully tested by me and an external VN node operator. |
AlexHentschel
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utilis cross-built, by taking into account the build machine support for ADX. This causes an issue when the build machine supports ADX and the target machine doesn't.This PR disables ADX in the built image so that the image works regardless of ADX support. This comes with a slight performance impact, which doesn't seem to be an issue for
util.Note that the image only works for the same arch as the build machine.