Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Time To Seal metric to access node to track time it takes to seal a transaction #6512

Merged
merged 26 commits into from
Oct 24, 2024
Merged

Add a Time To Seal metric to access node to track time it takes to seal a transaction #6512

merged 26 commits into from
Oct 24, 2024

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #6448.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.08333% with 94 lines in your changes missing coverage. Please review.

Project coverage is 41.12%. Comparing base (36f067d) to head (e316783).

Files with missing lines Patch % Lines
module/metrics/transaction.go 0.00% 44 Missing ⚠️
...chronization/indexer/collection_executed_metric.go 6.66% 27 Missing and 1 partial ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 11 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 6 Missing ⚠️
module/mock/access_metrics.go 0.00% 2 Missing ⚠️
module/mock/transaction_metrics.go 0.00% 2 Missing ⚠️
module/metrics/noop.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6512      +/-   ##
==========================================
- Coverage   41.14%   41.12%   -0.02%     
==========================================
  Files        2036     2036              
  Lines      179997   180089      +92     
==========================================
+ Hits        74060    74062       +2     
- Misses      99720    99814      +94     
+ Partials     6217     6213       -4
Flag Coverage Δ
unittests 41.12% <2.08%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua self-requested a review October 2, 2024 14:22
Guitarheroua
Guitarheroua approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have few small remarks.

peterargue
peterargue reviewed Oct 10, 2024
View reviewed changes
module/metrics/transaction.go Outdated Show resolved Hide resolved
module/metrics/transaction.go Outdated Show resolved Hide resolved
module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved
module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved
Guitarheroua
Guitarheroua approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franklywatson franklywatson added this pull request to the merge queue Oct 24, 2024
Merged via the queue into onflow:master with commit 0027ace Oct 24, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterargue peterargue peterargue left review comments

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@Guitarheroua Guitarheroua Guitarheroua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Time To Seal metric to access node to track time it takes to seal a transaction
6 participants
@AndriiDiachuk @codecov-commenter @zhangchiqing @Guitarheroua @peterargue @franklywatson