-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Refactor executionNodesForBlockID by encapsulating its parameters into a struct #6499
[Access] Refactor executionNodesForBlockID by encapsulating its parameters into a struct #6499
Conversation
…BlockID, backend and ingestion engine, updated tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6499 +/- ##
==========================================
+ Coverage 41.14% 41.19% +0.04%
==========================================
Files 2036 2036
Lines 179997 179972 -25
==========================================
+ Hits 74060 74134 +74
+ Misses 99720 99613 -107
- Partials 6217 6225 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…sages' of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6497-refactor-executionNodesForBlockID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…refactor-executionNodesForBlockID [Access] Refactor executionNodesForBlockID by encapsulating its parameters into a struct
…or-executionNodesForBlockID [Access] Refactor executionNodesForBlockID by encapsulating its parameters into a struct
…7-refactor-executionNodesForBlockID" This reverts commit 1a793e8.
Closes: #6497
Context
This pull request introduces a new struct,
ExecutionNodeIdentitiesProvider
, which encapsulates the parameters previously passed around multiple functions. This struct is initialized during instance creation and includes fields forexecutionReceipts
,state
,preferredENIdentifiers
,fixedENIdentifiers
and other relevant data.Changes:
ExecutionNodeIdentitiesProvider
struct.executionNodesForBlockID
and related functions to use the new struct instead of individual parameters.