Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally cache migration results #6041

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jun 5, 2024

Depends on #6052

@turbolent turbolent requested review from a team June 5, 2024 18:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.77%. Comparing base (3640d28) to head (d23bc11).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6041       +/-   ##
===========================================
+ Coverage   41.64%   50.77%    +9.12%     
===========================================
  Files        1958       66     -1892     
  Lines      137756     4528   -133228     
===========================================
- Hits        57372     2299    -55073     
+ Misses      74417     1982    -72435     
+ Partials     5967      247     -5720     
Flag Coverage Δ
unittests 50.77% <ø> (+9.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent requested a review from a team June 5, 2024 20:44
@turbolent turbolent changed the base branch from master to auto-update-onflow-cadence-v1.0.0-preview.33 June 6, 2024 19:50
Base automatically changed from auto-update-onflow-cadence-v1.0.0-preview.33 to master June 7, 2024 20:30
@turbolent turbolent enabled auto-merge June 7, 2024 20:58
@turbolent turbolent added this pull request to the merge queue Jun 7, 2024
Merged via the queue into master with commit 952cbe4 Jun 7, 2024
55 checks passed
@turbolent turbolent deleted the bastian/cache-migrations branch June 7, 2024 21:19
@j1010001
Copy link
Member

j1010001 commented Jun 8, 2024

@turbolent do you want the cache-static-type-migration and cache-entitlements-migration flags to be added to the C1.0 migration by default, of should we should run it first without and then re-run the migration with those flags enabled & compare the state commitments ?

@turbolent
Copy link
Member Author

@j1010001 No, these flags should not (yet) be added by default yet. Let's confirm they work properly first, see https://discord.com/channels/613813861610684416/1108479699732152503/1248754383143960758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants