Khalil/1908 fix gossipsub integration test #5323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5323 +/- ##
==========================================
+ Coverage 55.97% 55.98% +0.01%
==========================================
Files 1017 1017
Lines 98513 98513
==========================================
+ Hits 55145 55157 +12
+ Misses 39161 39148 -13
- Partials 4207 4208 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
can you add some context about what's going on in this PR to the description? |
yhassanzadeh13
approved these changes
Feb 7, 2024
| }) | ||
| t.Run("gossipsub spam mitigation invalid prunes", func(t *testing.T) { | ||
| testGossipSubSpamMitigationIntegration(t, p2pmsg.CtrlMsgPrune) | ||
| }) |
There was a problem hiding this comment.
Please also extend this test to iHave as well. Effectively, unknown, malformed and duplicate topics for iHave messages are also subsumed as spam attacks.
peterargue
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the intermittent issues observed in the TestGossipSubSpamMitigationIntegration. To enhance the stability of the test, the following improvements have been made:
Test Case Splitting:
The test has been divided into two distinct test cases, focusing on graft and prune control message types separately. This allows for more granular analysis and troubleshooting.
Control Message Volume Adjustment:
The volume of control messages sent during the test has been increased. This adjustment ensures that the penalized score is sustained for a longer duration than the time it takes for the score to decay. This modification guarantees the completion of the test within a reasonable timeframe.