[Flow EVM] reducing the scope of deposit to COAs only #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5280 +/- ##
=======================================
Coverage 55.60% 55.61%
=======================================
Files 1003 1003
Lines 96785 96785
=======================================
+ Hits 53818 53824 +6
+ Misses 38894 38892 -2
+ Partials 4073 4069 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
requested review from
turbolent,
janezpodhostnik and
sideninja
and removed request for
janezpodhostnik
sideninja
approved these changes
Jan 24, 2024
turbolent
approved these changes
Jan 24, 2024
Comment on lines
-19
to
-27
| /// Deposits the given vault into the EVM account with the given address | ||
| access(all) | ||
| fun deposit(from: @FlowToken.Vault) { | ||
| InternalEVM.deposit( | ||
| from: <-from, | ||
| to: self.bytes | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe also update the FLIP to reflect this change, both in the Cadence code, and also by adding a line or two that explains the rational (can just copy the description of the linked issue).
There was a problem hiding this comment.
the FLIP is updated with changes on the Cadence code side but I'll add a small explainer why its only available on the COAs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5227