Update event validation logic to account for the evm.* events
#5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good, but I also am working on this #5091 so I feel we can go either way. Longer solution is probably better to have an EVM specific type. |
m-Peter
force-pushed
the
update-flow-event-validation-logic
branch
from
903dce8 to
2f95f85
Compare
m-Peter
changed the title
flow.evm.* eventsevm.* events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
flowservice/protocol events, are allowed to have only 2 parts, e.g.flow.AccountCreated.The two newly-introduced EVM related events:
flow.evm.BlockExecutedflow.evm.TransactionExecuteddo not comply with this format, hence, they are considered as invalid event types:
rpc error: code = InvalidArgument desc = invalid event filter: invalid event type flow.evm.BlockExecuted: invalid event type: flow.evm.BlockExecuted