[Access] Index collections from execution data #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5163 +/- ##
==========================================
+ Coverage 56.44% 56.52% +0.08%
==========================================
Files 981 979 -2
Lines 93112 93132 +20
==========================================
+ Hits 52557 52644 +87
+ Misses 36666 36592 -74
- Partials 3889 3896 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
Dec 22, 2023
|
|
||
| // if more contiguous blocks are now complete, update db | ||
| if newLastFullHeight > lastFullHeight { | ||
| err = e.blocks.UpdateLastFullBlockHeight(newLastFullHeight) |
There was a problem hiding this comment.
nit: I think this index could be saved to a separate database( such as the Progress module), instead of the generic badger blocks. Other node type might not have the concept of "FullBlock"
There was a problem hiding this comment.
good call out. I opened an issue to track this: #5185
devbugging
reviewed
Dec 22, 2023
| @@ -716,14 +716,14 @@ func (builder *FlowAccessNodeBuilder) BuildExecutionSyncComponents() *FlowAccess | |||
|
|
|||
| checkpointHeight := builder.SealedRootBlock.Header.Height | |||
|
|
|||
| buutstrap, err := pStorage.NewRegisterBootstrap(pdb, checkpointFile, checkpointHeight, builder.Logger) | |||
| bootstrap, err := pStorage.NewRegisterBootstrap(pdb, checkpointFile, checkpointHeight, builder.Logger) | |||
There was a problem hiding this comment.
that was an itch for me 😄
devbugging
reviewed
Dec 22, 2023
devbugging
approved these changes
Dec 22, 2023
peterargue
added a commit
that referenced
this pull request
Jan 4, 2024
…cdata [Access] Index collections from execution data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4829