Backport PR 3050 to v0.27 to reduce memory and speedup checkpoint by splitting trie into subtries #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeIterator is modified to receive *node.Node instead of *trie.MTrie.
Replace very large Go map holding all unique nodes with smaller map of each subtrie to: - reduce operational memory by 37GB - reduce allocs by 19.6 million (50% of serialization allocs) - reduce duration by 2.7 minutes
fxamacker
requested review from
ramtinms,
m4ksio and
AlexHentschel
as code owners
zhangchiqing
approved these changes
Oct 5, 2022
Tonix517
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #3050 from master to branch v0.27.