[Test Fix / Bug Fix] [fix:TestEpochJoinAndLeaveAN] [fix:TestEpochJoinAndLeaveVN] Handle registering node without machine account
#2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the epoch tests would pass in an argument representing a machine account key, even for nodes which had no machine account. This worked because the SDK accepted an empty account key and the argument was ignored. An SDK API change caused this to no longer work, because the SDK will not accept empty account keys. Instead, we handle the case of an empty machine account explicitly by passing in a nil optional for this parameter.
jordanschalm
requested review from
SaveTheRbtz,
simonhf,
Kay-Zee and
pattyshack
as code owners
jordanschalm
requested review from
kc1116 and
gomisha
and removed request for
SaveTheRbtz,
simonhf,
Kay-Zee and
pattyshack
Codecov Report
@@ Coverage Diff @@
## master #2699 +/- ##
=======================================
Coverage 56.57% 56.57%
=======================================
Files 679 679
Lines 62475 62470 -5
=======================================
- Hits 35345 35343 -2
+ Misses 24120 24118 -2
+ Partials 3010 3009 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Can you add the names of all tests that should be fixed by this in the This would help when we quickly scan the list of open PRs in our master Epic tracking all flaky test work: [Test][Epic] Fix flaky tests #6255 |
jordanschalm
changed the title
TestEpochJoinAndLeaveAN] [fix:TestEpochJoinAndLeaveVN] Handle registering node without machine account
gomisha
approved these changes
Jun 28, 2022
peterargue
approved these changes
Jun 30, 2022
|
bors merge |
jordanschalm
changed the title
TestEpochJoinAndLeaveAN] [fix:TestEpochJoinAndLeaveVN] Handle registering node without machine account TestEpochJoinAndLeaveAN] [fix:TestEpochJoinAndLeaveVN] Handle registering node without machine account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the epoch tests would pass in an argument representing a machine account key, even for nodes which had no machine account. This worked because the SDK accepted an empty account key and the argument was ignored.
An SDK API change caused this to no longer work, because the SDK will not accept empty account keys.
Instead, we handle the case of an empty machine account explicitly by passing in a nil optional for this parameter. This should address the 0% success rate for AN/VN tests, which do not use machine accounts:
TestEpochJoinAndLeaveANTestEpochJoinAndLeaveVN