Secure cadence master update #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version because v1 is deprecated/sunset.
index ref_height->cluster_block_id on finalization
[Execution State] Full search json dump
Bump codecov-action v1 to v2
* update comments * add benchmark for index lookup
The emulator repo implements Headers, and is imported by flow-go, so the added method breaks test Added as a follow-up for another issue: onflow/flow-go-internal#6244
add flaky skip reason so tests can run in cron job
2385: Robust Transaction Deduplication r=jordanschalm a=jordanschalm This PR improves transaction de-duplication in collection nodes. It replaces a heuristic which de-duplicated based on the contents of a fixed number of ancestor collections, with an reference height index which enables de-duplicating transactions correctly in all cases including when the collection production rate significantly outpaces the consensus block rate. See also #2386 targeting the `v0.25` branch. ## Changes * Add an index mapping reference block height to collection ID, for non-empty finalized collections * Modify transaction inclusion validation when building and validating collections to take into account potentially conflicting collections at any point in the cluster state ancestry Co-authored-by: Jordan Schalm <[email protected]>
m4ksio
requested review from
ramtinms,
janezpodhostnik and
vishalchangrani
as code owners
turbolent
approved these changes
May 17, 2022
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 7bea1c3 The command Bench tests were run a total of 7 times on each branch. Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## feature/secure-cadence #2433 +/- ##
==========================================================
+ Coverage 56.28% 56.95% +0.67%
==========================================================
Files 653 653
Lines 40114 60019 +19905
==========================================================
+ Hits 22577 34183 +11606
- Misses 14658 22911 +8253
- Partials 2879 2925 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
j1010001
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master into secure cadence