Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for MTrie checkpoint file creation #1894

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Jan 25, 2022

Updates #1884 #1750 https://github.com/dapperlabs/flow-go/issues/6114

Changes include:

Add more logs during checkpoint file creation. Use INFO instead of DEBUG given the limited frequency and quantity of logs for checkpoint file creation.

These logs can be useful for detecting issues related to checkpoint creation. E.g. the checkpoint duration log can be used by log monitoring programs to alert us if it exceeds a threshold.

ledger/complete/wal/checkpointer.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1894 (e7de291) into master (244c6f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1894   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files         580      580           
  Lines       34474    34479    +5     
=======================================
+ Hits        20058    20061    +3     
- Misses      11805    11806    +1     
- Partials     2611     2612    +1     
Flag Coverage Δ
unittests 58.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ledger/complete/wal/checkpointer.go 63.73% <100.00%> (+0.37%) ⬆️
ledger/complete/wal/compactor.go 71.21% <100.00%> (+1.37%) ⬆️
ledger/complete/wal/wal.go 54.83% <100.00%> (ø)
...le/state_synchronization/execution_data_service.go 88.11% <0.00%> (-1.40%) ⬇️
admin/command_runner.go 79.20% <0.00%> (ø)
engine/collection/synchronization/engine.go 67.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244c6f1...e7de291. Read the comment docs.

@fxamacker fxamacker merged commit 2d896c8 into master Jan 26, 2022
@fxamacker fxamacker deleted the fxamacker/add-checkpoint-log branch January 26, 2022 01:24
@fxamacker fxamacker added the Execution Cadence Execution Team label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants