Update mtrie with some minor fixes and small improvements #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"rest" should only return rest of data. It was returning data+rest.
Buffer size in flattener.EncodeStorableTrie() was 2 bytes less which can cause additional buffer allocation.
In Ledger.Set(), PSMT.Update() returns error of type ledger.ErrMissingKeys. We don't need to convert error from ptrie.ErrMissingPath type because ledger.ErrMissingKeys type is being returned.
fxamacker
requested review from
AlexHentschel,
m4ksio and
ramtinms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
+ Coverage 58.08% 58.10% +0.02%
==========================================
Files 576 576
Lines 34227 34217 -10
==========================================
+ Hits 19880 19883 +3
+ Misses 11754 11741 -13
Partials 2593 2593
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AlexHentschel
approved these changes
Jan 6, 2022
ramtinms
reviewed
Jan 12, 2022
ramtinms
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1802
This PR updates mtrie with minor fixes and small improvements that don't break backward compatibility.
Changes include:
utils.ReadShortData()(commit 2b84aaa)flattener.EncodeStorableTrie()(commit 1fdfa14)Ledger.Set()(commit f93cb56)This was done while onboarding and getting familiar with mtrie code.