-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum go version to 1.16, and default to 1.17 #1692
Conversation
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 0e845f8 The command Bench tests were run a total of 7 times on each branch. Results
|
Codecov Report
@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
- Coverage 56.31% 56.31% -0.01%
==========================================
Files 554 554
Lines 32751 32751
==========================================
- Hits 18445 18443 -2
- Misses 11856 11858 +2
Partials 2450 2450
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
up to 15% performance improvement for the FVM 😮 |
5ea88c6
to
8393b33
Compare
bors merge |
1694: Update libp2p-tls to fix issue with secured gRPC certificate r=peterargue a=peterargue Depends on #1692, which updates the min go version to 1.16. Updates required to pull in this change: libp2p/go-libp2p-tls#100 The `libp2p/go-libp2p-tls` PR updates the certificate generated by the `NewIdentity` method to include subject and issuer fields, making it compliant with the x509 Certificate standard ([RFC3280](https://datatracker.ietf.org/doc/html/rfc3280#section-4.1.2)). This involves updating various other libp2p libraries, which now require go version 1.16. Co-authored-by: Peter Argue <[email protected]>
This updates the minimum go version to
1.16
, and the default version used in testing and docker containers to1.17
.