Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum go version to 1.16, and default to 1.17 #1692

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

peterargue
Copy link
Contributor

This updates the minimum go version to 1.16, and the default version used in testing and docker containers to 1.17.

@peterargue peterargue marked this pull request as draft November 29, 2021 20:48
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2021

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 0e845f8

The command go test ./fvm --bench . --tags relic -shuffle=on -count N was used.

Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeTransaction/get_public_account-230.4ms ± 1%32.7ms ± 3%+7.61%(p=0.002 n=6+6)
RuntimeTransaction/get_signer_address-227.8ms ± 3%29.8ms ± 3%+7.02%(p=0.001 n=6+7)
RuntimeTransaction/emit_event-242.1ms ± 4%44.4ms ± 3%+5.43%(p=0.002 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-229.3ms ± 1%30.5ms ± 3%+4.15%(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2341ms ± 4%354ms ± 4%+3.76%(p=0.011 n=7+7)
RuntimeTransaction/convert_int_to_string-228.1ms ± 2%29.1ms ± 3%+3.71%(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-237.4ms ± 3%38.7ms ± 3%+3.39%(p=0.011 n=7+7)
RuntimeTransaction/reference_tx-226.9ms ± 1%27.5ms ± 3%+2.58%(p=0.005 n=6+7)
RuntimeTransaction/transfer_tokens-2153ms ± 3%156ms ± 1%+1.89%(p=0.017 n=7+7)
RuntimeTransaction/get_account_and_get_balance-2447ms ± 1%457ms ± 4%~(p=0.234 n=6+7)
RuntimeTransaction/get_account_and_get_available_balance-2377ms ± 6%374ms ± 3%~(p=0.710 n=7+7)
RuntimeTransaction/get_signer_vault-236.7ms ± 4%36.6ms ± 1%~(p=0.836 n=7+6)
RuntimeTransaction/get_signer_receiver-245.4ms ± 3%46.1ms ± 2%~(p=0.097 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-236.0ms ± 5%35.8ms ± 3%~(p=0.535 n=7+7)
RuntimeTransaction/create_new_account-21.05s ± 2%1.05s ± 2%~(p=1.000 n=7+7)
RuntimeTransaction/call_empty_contract_function-236.0ms ± 3%36.7ms ± 3%~(p=0.383 n=7+7)
RuntimeNFTBatchTransfer-2116ms ± 2%113ms ± 1%−2.48%(p=0.001 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-238.5ms ± 5%37.2ms ± 4%−3.36%(p=0.026 n=7+7)
 

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #1692 (8393b33) into master (0e845f8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
- Coverage   56.31%   56.31%   -0.01%     
==========================================
  Files         554      554              
  Lines       32751    32751              
==========================================
- Hits        18445    18443       -2     
- Misses      11856    11858       +2     
  Partials     2450     2450              
Flag Coverage Δ
unittests 56.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/component/component.go 40.00% <0.00%> (-2.00%) ⬇️
admin/command_runner.go 79.20% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e845f8...8393b33. Read the comment docs.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gomisha gomisha self-requested a review November 30, 2021 18:10
@Kay-Zee
Copy link
Member

Kay-Zee commented Nov 30, 2021

up to 15% performance improvement for the FVM 😮

@peterargue
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 30, 2021

@bors bors bot merged commit c5ee8b7 into master Nov 30, 2021
@bors bors bot deleted the petera/update-min-go-1.16 branch November 30, 2021 19:36
bors bot added a commit that referenced this pull request Nov 30, 2021
1694: Update libp2p-tls to fix issue with secured gRPC certificate r=peterargue a=peterargue

Depends on #1692, which updates the min go version to 1.16.

Updates required to pull in this change: libp2p/go-libp2p-tls#100

The `libp2p/go-libp2p-tls` PR updates the certificate generated by the `NewIdentity` method to include subject and issuer fields, making it compliant with the x509 Certificate standard ([RFC3280](https://datatracker.ietf.org/doc/html/rfc3280#section-4.1.2)).

This involves updating various other libp2p libraries, which now require go version 1.16.

Co-authored-by: Peter Argue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants