Skip to content

refactor: replace golang.org/x/exp with stdlib#774

Merged
m-Peter merged 1 commit into
onflow:mainfrom
StevenMia:main
Mar 10, 2025
Merged

refactor: replace golang.org/x/exp with stdlib#774
m-Peter merged 1 commit into
onflow:mainfrom
StevenMia:main

Conversation

@StevenMia
Copy link
Copy Markdown
Contributor

@StevenMia StevenMia commented Mar 9, 2025

Closes: #???

Description

Since Go 1.21, the functions in x/exp used here can already be replaced by functions from the standard library


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies for slice operations to use a standard library module. These changes improve internal consistency without impacting any user-facing functionality.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 9, 2025

Walkthrough

This pull request updates import statements in two Go files. In both services/logs/filter.go and services/requester/cross-spork_client.go, the previously used experimental import "golang.org/x/exp/slices" is replaced with a direct import of the standard library package "slices". No changes to business logic, error handling, or public interfaces were made.

Changes

File(s) Change Summary
services/logs/filter.go
services/requester/cross-spork_client.go
Updated import statements: removed "golang.org/x/exp/slices" and added standard library import "slices".

Possibly related PRs

Suggested labels

Improvement, Chore

Suggested reviewers

  • peterargue
  • zhangchiqing
  • m-Peter

Poem

I'm just a bunny in the coding wood,
Hopping through imports as all bunnies should.
Replacing paths and slicing with cheer,
In Go's garden, everything's crystal clear.
Here's to changes that make our code dear! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b83d7b1 and ec4730e.

📒 Files selected for processing (2)
  • services/logs/filter.go (1 hunks)
  • services/requester/cross-spork_client.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • services/requester/cross-spork_client.go
  • services/logs/filter.go

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌 Thanks for your contribution!

@m-Peter
Copy link
Copy Markdown
Collaborator

m-Peter commented Mar 10, 2025

@StevenMia There are some linting errors, could you try to resolve them?

@StevenMia
Copy link
Copy Markdown
Contributor Author

workflow awaiting approval

It seems that the CI failure is not directly related to this modification.

However, I'm happy to investigate the cause. I submitted an empty file to trigger the CI, but it requires approval from the maintainer.

@m-Peter
Copy link
Copy Markdown
Collaborator

m-Peter commented Mar 10, 2025

workflow awaiting approval

It seems that the CI failure is not directly related to this modification.

However, I'm happy to investigate the cause. I submitted an empty file to trigger the CI, but it requires approval from the maintainer.

This is what I see:

Error: File is not properly formatted (goimports)

So most likely, the 2 files changed by this PR, have some formatting issue.

Signed-off-by: StevenMia <flite@foxmail.com>
@StevenMia
Copy link
Copy Markdown
Contributor Author

This is what I see:

Error: File is not properly formatted (goimports)

So most likely, the 2 files changed by this PR, have some formatting issue.

Oh, yes, I have modified this problem. Please approve CI to rerun it.

@StevenMia
Copy link
Copy Markdown
Contributor Author

Currently on my own branch, it has been passed.

https://github.com/StevenMia/flow-evm-gateway/actions/runs/13763268775/job/38483900613

@StevenMia
Copy link
Copy Markdown
Contributor Author

Great! They all passed!

@m-Peter m-Peter merged commit 2106e51 into onflow:main Mar 10, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Aug 21, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants