Adds rewards calculation for sporks #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
requested review from
jordanschalm,
janezpodhostnik and
satyamakgec
jordanschalm
approved these changes
Apr 26, 2023
| false, | ||
| ) | ||
|
|
||
| // Verifies that the rewards from the previous epoch does not include the new epoch's amount |
There was a problem hiding this comment.
When we spork, the rewards for the epoch pre-spork will be paid out when the resetEpoch transaction is submitted. Currently this is the next day, on Thursday. It would be ideal if this multisig could be moved to Wednesday, so there isn't a 1-day delay in reward payouts, once this is enabled. cc @vishalchangrani
There was a problem hiding this comment.
Agreed, it would be nice to reset on the same day as the spork
jordanschalm
added a commit
to onflow/flow-go
that referenced
this pull request
Apr 27, 2023
In onflow/flow-core-contracts#365, we removed the payout argument from the resetEpoch transaction and function. Here, we update the CLI tool which generates arguments for this transaction accordingly.
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
May 1, 2023
4286: Remove payout flag, arg from resetEpoch cmd r=jordanschalm a=jordanschalm In onflow/flow-core-contracts#365, we removed the payout argument from the resetEpoch transaction and function. Here, we update the CLI tool which generates arguments for this transaction accordingly. Co-authored-by: Jordan Schalm <[email protected]>
KshitijChaudhary666
added a commit
to onflow/flips
that referenced
this pull request
Jun 6, 2023
This has been implemented (on 5/3). See the following PRs - onflow/service-account#238 onflow/flow-core-contracts#352 onflow/flow-core-contracts#365
KshitijChaudhary666
added a commit
to onflow/flips
that referenced
this pull request
Jun 6, 2023
This has been implemented (on 5/3). See the following PRs - onflow/service-account#238 onflow/flow-core-contracts#352 onflow/flow-core-contracts#365
dsainati1
pushed a commit
to onflow/flips
that referenced
this pull request
Jul 11, 2023
This has been implemented (on 5/3). See the following PRs - onflow/service-account#238 onflow/flow-core-contracts#352 onflow/flow-core-contracts#365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a spork, the
FlowEpoch.heartbeat.resetEpoch()method is called after the spork is complete.If automatic rewards are enabled, the reward breakdown for the current epoch needs to be calculated and rewards for the next epoch need to be calculated.
This PR adds
calculateAndSetRewards()to theresetEpoch()method so this is done properly and automatic rewards can be paid after a spork.The creation of new epoch metadata has also been moved to before the start of the new epoch in order to have valid epoch metadata for the rewards calculations to modify. This is why it now creates an
EpochMetadatawithcounter + 1This also removes the rewards parameter from
resetEpoch()because it is not used any more