New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expressions in string template #3662

Draft

RZhang05 wants to merge 3 commits into onflow:master from RZhang05:expression-string-template

Contributor

RZhang05 commented Oct 30, 2024

Working towards #3579

Description

This PR extends the work in #3585, as planned to support expressions.

Reopening of #3625

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

RZhang05 added 3 commits

October 30, 2024 17:05


          Remove identifier constraint, add tests.

ba580e2


          Add more tests for expressions in string templates.

d93bb65


          Update tests.

ce4bb74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

turbolent Awaiting requested review from turbolent turbolent will be requested when the pull request is marked ready for review turbolent is a code owner

SupunS Awaiting requested review from SupunS SupunS will be requested when the pull request is marked ready for review SupunS is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet