Add reference tracking for the result variable #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked for other places where references are created internally but not tracked; Seems the only remaining ones are related to attachments. I'm not really sure which one of those actually needs to be tracked, etc. @dsainati1 Can you maybe have a look? Just look for the usages of |
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 147e51e Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2447 +/- ##
=======================================
Coverage 78.31% 78.31%
=======================================
Files 325 325
Lines 72330 72342 +12
=======================================
+ Hits 56646 56658 +12
Misses 13606 13606
Partials 2078 2078
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
turbolent
approved these changes
Apr 14, 2023
dsainati1
approved these changes
Apr 17, 2023
|
Should this be merged into the
I took a look when I merged attachments into Stable Cadence. The only reference we need to track there is the references created via attachment access |
Reference tracking was already there in master/previous releases, but used for a different purpose: to keep the reference valid even after the resource is moved (i.e: to make it point to the correct resource instance). It was only re-purposed in Stable Cadence, to use it for invalidation.
Similar to the example here, wouldn't it be possible to store the reference to the base/self temporarily, and return the reference later (in the same execution), but after the refrenced resource (attachment) is moved? |
SupunS
force-pushed
the
supun/resource-tracking
branch
from
af7f97c
to
b743004
Compare
SupunS
commented
Apr 17, 2023
|
@turbolent @dsainati1 Can you have one final look, please? |
turbolent
approved these changes
Apr 19, 2023
dsainati1
approved these changes
Apr 19, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up on #2444.
masterbranchFiles changedin the Github PR explorer