Use go1.21 slices package in map #532
Open
+32
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.21 introduced the slices package, so we can replace some code by using it to improve readability and maintenance. This commit simplifies insertion, removal, and clone for slices in map non-test code by using these slices pkg functions: - slices.Insert() - slices.Delete() - slices.Clone()
turbolent
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #464
Go 1.21 introduced the
slicespackage, so we can replace some code by using it to improve readability and maintenance.This commit simplifies insertion, removal, and clone for slices in map non-test code by using:
slices.Insert()slices.Delete()slices.Clone()NOTE: This PR changes non-test code, so I briefly ran smoke tests locally on this code and no problems were detected. Longer smoke tests will be run before next release tag.
mainbranchFiles changedin the Github PR explorer