Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch tab order #500

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Switch tab order #500

wants to merge 2 commits into from

Conversation

bthaile
Copy link
Collaborator

@bthaile bthaile commented Feb 11, 2025

Related Issue

Closes #499

Summary of Changes

Update tab order to have Accounts first. This will give client parity.

Need Regression Testing

Shifted tab order, make sure the tabs behave as expected.
Renamed UI component from TokenPrice to TokenValue since it's scope has increased.

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

image

@bthaile bthaile changed the base branch from master to dev February 11, 2025 23:33
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Collaborator

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If at all possible, could you please delay merging this. Almost all your changes will be wiped out by the changes we're making to Send component. Sorry! It might be easier to redo this code afterwards. Going to mark as request changes for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send workflow shift tab order
2 participants