Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance PrivateRoute component with async wallet state checks #265

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

tombeckenham
Copy link
Collaborator

Related Issue

Closes #260

Summary of Changes

  • Added useState hooks to manage booted, unlocked, and loading states.
  • Implemented useEffect to asynchronously check wallet boot and unlock status.
  • Updated render logic to handle loading state and redirect based on wallet status.

Need Regression Testing

It's a small change, but an important one that affects the ability for the user to get to most parts of the extension.

  • [ X] Yes
  • No

Risk Assessment

Bug fix that affects the loading routes

  • Low
  • [ X] Medium
  • High

- Added useState hooks to manage booted, unlocked, and loading states.
- Implemented useEffect to asynchronously check wallet boot and unlock status.
- Updated render logic to handle loading state and redirect based on wallet status.
@tombeckenham tombeckenham merged commit f3303e2 into dev Dec 9, 2024
2 checks passed
@tombeckenham tombeckenham deleted the 260-bug-async-issue-with-privateroute branch December 9, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants