Pass processIdentifier when checking cache in ImagePrefetcher #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this parameter, ImagePrefetcher will have a cache miss whenever a user passes any ImageProcessor other than DefaultImageProcessor, regardless of whether that image has already been downloaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this parameter,
ImagePrefetcherwill have a cache miss whenever a user passes any ImageProcessor other than DefaultImageProcessor, regardless of whether that image has already been downloadedFixes #589.
This should be fairly easy to write a unit test for, but I couldn't get the tests to work because there was a bunch of missing assets in the Copy Bundle Resources.