Skip to content

Another way of adding kf namespacing #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 17, 2016
Merged

Another way of adding kf namespacing #441

merged 6 commits into from
Sep 17, 2016

Conversation

webfrogs
Copy link
Contributor

Change the way of implement namespacing extension #435

@webfrogs webfrogs mentioned this pull request Sep 16, 2016
@webfrogs webfrogs changed the title Another way of add kf namespacing Another way of adding kf namespacing Sep 16, 2016
@codecov-io
Copy link

codecov-io commented Sep 17, 2016

Current coverage is 74.15% (diff: 65.47%)

Merging #441 into master will decrease coverage by 2.38%

@@             master       #441   diff @@
==========================================
  Files            20         21     +1   
  Lines          2106       2194    +88   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1612       1627    +15   
- Misses          494        567    +73   
  Partials          0          0          

Powered by Codecov. Last update 2c8ebc8...86159a4

@onevcat
Copy link
Owner

onevcat commented Sep 17, 2016

@webfrogs LGTM

@onevcat onevcat merged commit 6c81e4e into onevcat:master Sep 17, 2016
rain2540 pushed a commit to rain2540/Kingfisher that referenced this pull request Feb 28, 2017
Another way of adding kf namespacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants