Workaround a closure based generator leak in Swift #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This p-r fixes an issue in Swift Generator. This is reported here: #280
After some research, I found when using a closure based generator, a leak will happen in Release build in
_GeneratorBox.__allocating_init(A) -> _GeneratorBox
. It does not relate to Kingfisher's code, since there are some minimal examples are also reported to be leaking by Instruments.Turn to a normal
GeneratorType
instead of closure based one could solve this problem.