ImageCache - custom cache path #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2015 10:09
- Added custom cache path to ImageCache init (if you need a custom image cache location) - Made diskCachePath public so a user can see where the images are being stored on disk - Made cachePathForKey and cacheFileNameForKey public so an image cache could be constructed easily from existing files
use hashForKey instead
| let cache = ImageCache(name:"test",path:customPath) | ||
| XCTAssert(cache.diskCachePath == customPath,"Custom disk cache path set correctly") | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Line #59 should have no trailing whitespace
|
Great! Thanks a lot for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional path parameter to init. This is really useful for me as I want a cache in documents dir for user generated photos, and also to make the ImageCache backwards compatible from an existing cache.