Allow responses to work with only an idp_cert_multi setting #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the settings only contain an idp_cert_multi fingerprint the responses cannot be validated because it is wrongly assumes that the certificate cannot be checked. Include the idp_cert_multi setting in this check as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the settings only contain an idp_cert_multi fingerprint the
responses cannot be validated because it is wrongly assumes that the
certificate cannot be checked.
Include the idp_cert_multi setting in this check as well.
It may be helpful to move this check into settings, e.g. by providing a settings.has_idp_cert? method but I have not done so yet at this point.