Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem parsing a metadata file #401

Closed
jensljungblad opened this issue Jun 1, 2017 · 6 comments
Closed

Problem parsing a metadata file #401

jensljungblad opened this issue Jun 1, 2017 · 6 comments

Comments

@jensljungblad
Copy link

We have a metadata file that we are trying to parse with get_idp_metadata but it fails to return idp_cert and idp_cert_fingerprint. It does return idp_cert_multi however.

Here is the metadata file: https://login.lararforbundet.se/federationmetadata/2007-06/federationmetadata.xml

@pitbulk
Copy link
Collaborator

pitbulk commented Jun 1, 2017

That happens because different IdP cert is used to sign and encrypt, and now we support different certs for each functionality.

You will be ok using directly idp_cert_multi on the settings (idp_cert and idp_certifingerprint will be ignored then).

Review the documentation about this new feature

@Linuus
Copy link

Linuus commented Jun 1, 2017

Hi!

Our settings look like this:

 :idp_cert=>nil,
 :idp_cert_fingerprint=>nil,
 :idp_cert_multi=>
  {"signing"=>
    ["MIIC6...."],
   "encryption"=>
    ["MIIC8...."]}}

But we still get this error:
Authentication failure! invalid_ticket: OneLogin::RubySaml::ValidationError, No fingerprint or certificate on settings

If I understand correctly it should ignore :idp_certand :idp_cert_fingerprint since we have the :idp_cert_multi parameter?

@borourke
Copy link

borourke commented Jul 3, 2017

Yes, we also have the same issue. We get:

irb(main):120:0> response.errors
=> ["No fingerprint or certificate on settings"]

even though our settings file looks like this:

settings.idp_cert_multi                 = { signing: [signing], encryption: [encryption] }

Please look into this as it's pretty clear that is_valid? runs validate method, and first line of validate method is: https://github.com/onelogin/ruby-saml/blob/52472021725be64e25bed93cbba2259717ed573b/lib/onelogin/ruby-saml/response.rb#L410-L420

@pitbulk
Copy link
Collaborator

pitbulk commented Jul 4, 2017

You are right, I will fix that

@borourke
Copy link

borourke commented Jul 4, 2017

Thanks, appreciated!

@pitbulk
Copy link
Collaborator

pitbulk commented Jul 6, 2017

Fixed with #402

@pitbulk pitbulk closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants