Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes handling of some soft and hard validation failures. #139

Merged
merged 6 commits into from
Sep 18, 2014

Conversation

phene
Copy link
Contributor

@phene phene commented Jul 14, 2014

  • Supports soft validation of missing X509Certificate
  • Supports hard validation of SAML Response Status
  • Fixes issue with attribute parsing when EncryptedAttribute elements lack names.

@Lordnibbler
Copy link
Contributor

👍 lgtm, @luisvm @pitbulk @inakidelamadrid can you review please

@Lordnibbler
Copy link
Contributor

@phene Can you rebase this branch off master? @pwnetrationguru @luisvm @pitbulk can you review?

@phene
Copy link
Contributor Author

phene commented Sep 18, 2014

Updated against master.

@Lordnibbler
Copy link
Contributor

@pwnetrationguru @luisvm @pitbulk please review !!!!!!

@pwnetrationguru
Copy link
Contributor

👍 💥
Thanks for the patience and contributions, @phene!

@luisvm
Copy link
Contributor

luisvm commented Sep 18, 2014

👍 this is looking good, what do you say @pitbulk ?

Lordnibbler added a commit that referenced this pull request Sep 18, 2014
Fixes handling of some soft and hard validation failures.
@Lordnibbler Lordnibbler merged commit 4e15a94 into SAML-Toolkits:master Sep 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants