Fixes handling of some soft and hard validation failures. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phene
commented
Jul 14, 2014
phene
commented
- Supports soft validation of missing X509Certificate
- Supports hard validation of SAML Response Status
- Fixes issue with attribute parsing when EncryptedAttribute elements lack names.
|
👍 lgtm, @luisvm @pitbulk @inakidelamadrid can you review please |
|
@phene Can you rebase this branch off master? @pwnetrationguru @luisvm @pitbulk can you review? |
phene
force-pushed
the
better-validation
branch
from
a95f86a
to
5173f45
Compare
|
Updated against master. |
|
@pwnetrationguru @luisvm @pitbulk please review !!!!!! |
|
👍 💥 |
|
👍 this is looking good, what do you say @pitbulk ? |
Lordnibbler
added a commit
that referenced
this pull request
Sep 18, 2014
Fixes handling of some soft and hard validation failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.