[ur] Improve reporting of adapter specific errors #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alycm
reviewed
Jun 12, 2023
alycm
reviewed
Jun 12, 2023
kbenzie
force-pushed
the
benie/platform-get-last-error
branch
from
b2b8a1a to
bf91b29
Compare
kbenzie
changed the title
veselypeta
approved these changes
Jun 14, 2023
pbalcer
approved these changes
Jun 14, 2023
Remove the `urGetLastResult()` entry-point and replace it with `urPlatformGetLastError()`. This primary difference is the addition of the `pError` out parameter which returns an error code emitted from a failed driver entry-point which resulted in a Unified Runtime entry-point returning `UR_RESULT_ERROR_ADAPTER_SPECIFIC`. Fixes oneapi-src#500.
kbenzie
force-pushed
the
benie/platform-get-last-error
branch
from
bf91b29 to
d05083c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
urGetLastResult()entry-point and replace it withurPlatformGetLastError(). This primary difference is the addition ofthe
pErrorout parameter which returns an error code emitted from afailed driver entry-point which resulted in a Unified Runtime
entry-point returning
UR_RESULT_ERROR_ADAPTER_SPECIFIC.Fixes #500.