Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Extend OS testing matrix #484

Merged
merged 1 commit into from
May 22, 2023

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented May 1, 2023

Partially address #457 by adding Ubuntu 20.04 and Windows Server 2019 to
the testing matrix. These are the low hanging fruit, beyond these
additions we'll need to use container images.

@kbenzie kbenzie force-pushed the benie/extend-os-matrix branch 2 times, most recently from c95a797 to 628715c Compare May 1, 2023 14:21
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering - is there any reason why this PR is unfinished and marked as a draft...?

@kbenzie kbenzie force-pushed the benie/extend-os-matrix branch 2 times, most recently from 0fc74a5 to ada2c8e Compare May 18, 2023 15:17
Partially address oneapi-src#457 by adding Ubuntu 20.04 and Windows Server 2019 to
the testing matrix. These are the low hanging fruit, beyond these
additions we'll need to use container images.
@kbenzie kbenzie force-pushed the benie/extend-os-matrix branch from ada2c8e to 99b520d Compare May 22, 2023 10:05
@kbenzie kbenzie marked this pull request as ready for review May 22, 2023 10:19
Copy link
Contributor

@fabiomestre fabiomestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I don't have much knowledge of github ci. So it would be useful if someone else would have a look.

@pbalcer
Copy link
Contributor

pbalcer commented May 22, 2023

Ideally, I'd like for @lukaszstolarczuk to take a look, but he's vacationing this week ;)

@pbalcer pbalcer merged commit 77e0a22 into oneapi-src:main May 22, 2023
@lukaszstolarczuk
Copy link
Contributor

FYI, I looked into this previously - it looks good to me 😉

@kbenzie kbenzie deleted the benie/extend-os-matrix branch January 29, 2024 13:48
@kbenzie kbenzie restored the benie/extend-os-matrix branch January 29, 2024 13:48
@kbenzie kbenzie deleted the benie/extend-os-matrix branch June 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants