[UR] urDeviceSelectBinary spec changes
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
changed the title
urDeviceSelectBinary matches PI
veselypeta
force-pushed
the
petr/252/binary-structs
branch
4 times, most recently
from
7544a93 to
a233e69
Compare
kbenzie
reviewed
Mar 10, 2023
veselypeta
force-pushed
the
petr/252/binary-structs
branch
3 times, most recently
from
ddf490e to
1257117
Compare
veselypeta
changed the title
urDeviceSelectBinary matches PIurDeviceSelectBinary spec changes
veselypeta
force-pushed
the
petr/252/binary-structs
branch
from
1257117 to
a0c0e93
Compare
The module object has been removed, and the program object now more closely mirrors its OpenCL and PI equivalents.
veselypeta
force-pushed
the
petr/252/binary-structs
branch
from
a0c0e93 to
5867e35
Compare
kbenzie
reviewed
Mar 17, 2023
aarongreig
reviewed
Mar 17, 2023
veselypeta
force-pushed
the
petr/252/binary-structs
branch
from
5867e35 to
dd24bfb
Compare
aarongreig
reviewed
Mar 17, 2023
veselypeta
force-pushed
the
petr/252/binary-structs
branch
from
dd24bfb to
8077602
Compare
aarongreig
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PI uses a
pi_device_binarytype which includes a bunch of additional metadata that is used by the program manager in SYCL. However the only place where this binary struct is used is with theurDeviceSelectBinaryentry point. Every implemented plugin selects the correct device binary by comparing the correctDeviceTargetSpecwithin the plugin. The extra complexity inherited in PI from the program manager is unnecessary for UR and has been removed. I have left the option of extending this struct with theur_base_desc_tclass.Closes #252
Closes #118
Closes #171
Closes #114