Change MAX_MEMORY_BANDWIDTH device query to uint64 #2653
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarahmed1111
force-pushed
the
change-MAX_MEMORY_BANDWIDTH-device-query-to-int64
branch
3 times, most recently
from
f3775e3 to
3c22a26
Compare
omarahmed1111
force-pushed
the
change-MAX_MEMORY_BANDWIDTH-device-query-to-int64
branch
from
3c22a26 to
8922e51
Compare
github-actions
bot
added
conformance
omarahmed1111
changed the title
aarongreig
reviewed
Feb 5, 2025
omarahmed1111
force-pushed
the
change-MAX_MEMORY_BANDWIDTH-device-query-to-int64
branch
2 times, most recently
from
7a156bd to
35c8baa
Compare
aarongreig
approved these changes
Feb 6, 2025
ldrumm
reviewed
Feb 6, 2025
|
|
||
| uint32_t MemoryBandwidth = MemoryClockKHz * MemoryBusWidth * 250; | ||
| uint64_t MemoryBandwidth = |
There was a problem hiding this comment.
If this is bits per second, don't we need to multiply by 1000 to account for the kHz aspect?
There was a problem hiding this comment.
Also where does the MemoryBandwidthConstant come from? I know it was already there, but have providence comments for magic numbers would be useful.
Also, since it's putatively a constant: const or constexpr, please
There was a problem hiding this comment.
I think the original equation is meant to use it as KHz to get it as b/s. I added a comment explaining how to get this constant from in the nvidia doc page. Do you think that should be enough or should I write the computation constants also in a comment?
omarahmed1111
force-pushed
the
change-MAX_MEMORY_BANDWIDTH-device-query-to-int64
branch
from
35c8baa to
807196a
Compare
omarahmed1111
force-pushed
the
change-MAX_MEMORY_BANDWIDTH-device-query-to-int64
branch
from
807196a to
804e82d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max value that could be assigned to
MemoryBandwidthvariable is (250 * 3200000 * 256) which will overflow the uint32 max capacity. so we should change that to be uint64 to fit the maximum value from this computation.