[HIP] Implement urKernelSuggestMaxCooperativeGroupCountExp for HIP #2617
Conversation
|
cc @GeorgeWeb |
source/adapters/hip/kernel.cpp
Outdated
| &MaxNumActiveGroupsPerCU, hKernel->get(), localWorkSize, | ||
| dynamicSharedMemorySize)); | ||
| detail::ur::assertion(MaxNumActiveGroupsPerCU >= 0); | ||
| // Handle the case where we can't have all SMs active with at least 1 group |
There was a problem hiding this comment.
I think AMD calls these WGPs (Work-Group Processors). SM is for Nvidia architectures.
GeorgeWeb
left a comment
GeorgeWeb
left a comment
There was a problem hiding this comment.
Could you please describe the changes a little more in the description field of this PR? It is used as part of the final squashed commit's message alongside the title upon merge. Thank you.
|
@GeorgeWeb |
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide has been updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days. Should you wish to continue with your PR you will need to migrate it to intel/llvm. This is an automated comment. |
Unified Runtime -> intel/llvm Repo Move NoticeFollowing on from the previous notice, we have now enabled workflows to automatically label and close PRs because the Unified Runtime source code has moved to intel/llvm. This PR has now been marked with the Please review the previous notice for more information, including assistance with migrating your PR to intel/llvm. Should there be a reason for this PR to remain open, manually remove the This is an automated comment. |
Automatic PR Closure NoticeInformationThis PR has been closed automatically. It was marked with the All Unified Runtime development should be done in intel/llvm, details can be found in the updated contribution guide. Next StepsShould you wish to re-open this PR it must be moved to intel/llvm. We have provided a script to help automate this process, otherwise no actions are required. This is an automated comment. |
5 participants
This commit follows the implementation #1796 to support the experimental urKernelSuggestMaxCooperativeGroupCountExp, for the HIP adapter, to retrieve the maximum number of cooperative groups that can be launched on the device.
Additionally, the changes also cache the result of the hipDeviceAttributeMultiprocessorCount query which is used to calculate the device-wide maximum cooperative groups, because the HIP occupancy query used has per multiprocessor semantics.