[ur] Remove null adapter default load #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
force-pushed
the
petr/fix-test-interface
branch
from
d1b6bbd to
af59031
Compare
pbalcer
reviewed
Feb 14, 2023
veselypeta
force-pushed
the
petr/fix-test-interface
branch
3 times, most recently
from
3fdebfb to
b23004b
Compare
veselypeta
force-pushed
the
petr/fix-test-interface
branch
from
b23004b to
2ec1153
Compare
veselypeta
commented
Feb 14, 2023
Comment on lines
24
to
39
| static const char *knownAdaptersNames[] = { | ||
| MAKE_LIBRARY_NAME("ur_null", UR_VERSION), | ||
| }; | ||
|
|
||
| std::vector<PlatformLibraryPath> discoverEnabledPlatforms() { | ||
| std::vector<PlatformLibraryPath> enabledPlatforms; | ||
|
|
||
| // UR_ADAPTERS_FORCE_LOAD is for development/debug only | ||
| char *altPlatforms = nullptr; | ||
| _dupenv_s(&altPlatforms, NULL, "UR_ADAPTERS_FORCE_LOAD"); | ||
|
|
||
| if (altPlatforms == nullptr) { | ||
| for (auto libName : knownAdaptersNames) { | ||
| enabledPlatforms.emplace_back(libName); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Unfortunately I had to remove knownAdaptersNames from the windows build as the MSVC compiler is quite picky about zero-length arrays. Perhaps I should remove from linux equivalent too?
There was a problem hiding this comment.
You could use std::array. zero-length std:array is well defined so Windows should not complain. But if we don't have any adapters yet removing it will work as well I guess.
There was a problem hiding this comment.
Yea, I wouldn't worry about removing this if you need to - this code needs to be refactored anyway.
pbalcer
approved these changes
Feb 15, 2023
winstonzhang-intel
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Jan 28, 2025
URT PR: oneapi-src/unified-runtime#261 Signed-off-by: Zhang, Winston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.