fix parseDisjointPoolConfig and add tests #2574
Merged
+90
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
added
memory
bratpiorka
force-pushed
the
rrudnick_fix_usm_pool_config_parse
branch
2 times, most recently
from
1e63428 to
61514b2
Compare
igchor
reviewed
Jan 16, 2025
bratpiorka
force-pushed
the
rrudnick_fix_usm_pool_config_parse
branch
4 times, most recently
from
3de8bac to
8ee9060
Compare
igchor
approved these changes
Jan 17, 2025
bratpiorka
force-pushed
the
rrudnick_fix_usm_pool_config_parse
branch
from
8ee9060 to
fac2de2
Compare
bratpiorka
force-pushed
the
rrudnick_fix_usm_pool_config_parse
branch
from
fac2de2 to
07001aa
Compare
pbalcer
approved these changes
Jan 24, 2025
|
Pulled in by intel/llvm#16791 instead. |
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix parseDisjointPoolConfig() (which parses the SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR environment variable) + add basic tests
this is a fix for #2544
intel/llvm: intel/llvm#16708