Skip to content

[L0] Fixed event leak when outevent is given and is completed #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

winstonzhang-intel
Copy link
Contributor

@winstonzhang-intel winstonzhang-intel commented Dec 12, 2024

During urEnqueueEventsWait, when an OutEvent is given we do not properly clean up after the event is completed. This patch addresses that.

llvm/sycl: intel/llvm#16339

@nrspruit
Copy link
Contributor

looks like this causes a segfault in the multi device tests:

Start 29: test-adapter-level_zero_ze_calls

2/4 Test #29: test-adapter-level_zero_ze_calls ......***Exception: SegFault 0.23 sec
ZE_LOADER_DEBUG_TRACE:zeInitDrivers called first, but not supported by driver, returning uninitialized.
Selected platform: [LEVEL_ZERO] Intel(R) oneAPI Unified Runtime over Level-Zero
[==========] Running 48 tests from 1 test suite.

is it possible the out event is being freed twice?

@winstonzhang-intel winstonzhang-intel marked this pull request as ready for review December 13, 2024 19:53
@winstonzhang-intel winstonzhang-intel requested a review from a team as a code owner December 13, 2024 19:53
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM

@nrspruit nrspruit added v0.11.x Include in the v0.11.x release ready to merge Added to PR's which are ready to merge labels Dec 13, 2024
@kbenzie kbenzie merged commit 68d93ef into oneapi-src:main Dec 16, 2024
72 of 73 checks passed
kbenzie added a commit that referenced this pull request Dec 16, 2024
[L0] Fixed event leak when outevent is given and is completed
sarnex pushed a commit to intel/llvm that referenced this pull request Dec 16, 2024
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 19, 2025
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 19, 2025
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants