-
Notifications
You must be signed in to change notification settings - Fork 124
[L0] Fixed event leak when outevent is given and is completed #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zhang, Winston <[email protected]>
3b9baa3
to
fbd8794
Compare
looks like this causes a segfault in the multi device tests:
2/4 Test #29: test-adapter-level_zero_ze_calls ......***Exception: SegFault 0.23 sec is it possible the out event is being freed twice? |
Signed-off-by: Zhang, Winston <[email protected]>
ebde7f4
to
3756b45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM
[L0] Fixed event leak when outevent is given and is completed
Pulls in the following bug fixes: * oneapi-src/unified-runtime#2447 * oneapi-src/unified-runtime#2449 * oneapi-src/unified-runtime#2452 * oneapi-src/unified-runtime#2452 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Pulls in the following bug fixes: * oneapi-src/unified-runtime#2447 * oneapi-src/unified-runtime#2449 * oneapi-src/unified-runtime#2452 * oneapi-src/unified-runtime#2452 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Pulls in the following bug fixes: * oneapi-src/unified-runtime#2447 * oneapi-src/unified-runtime#2449 * oneapi-src/unified-runtime#2452 * oneapi-src/unified-runtime#2452 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Pulls in the following bug fixes: * oneapi-src/unified-runtime#2447 * oneapi-src/unified-runtime#2449 * oneapi-src/unified-runtime#2452 * oneapi-src/unified-runtime#2452 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
During urEnqueueEventsWait, when an OutEvent is given we do not properly clean up after the event is completed. This patch addresses that.
llvm/sycl: intel/llvm#16339