Align Kernel CTS and Specification. #2444

isaacault · 2024-12-10T16:20:08Z

Separate parameterized tests. Progresses Restructure GetInfo CTS tests to use separate tests instead of a switch #2290.
urKernelGetGroupInfo CompileWorkGroupSize test modified to use distinct dimensions.
urKernelSetArgPointer no longer returns invalid argument size.
Testcases added:
- urKernelGetGroupInfo CompileMaxWorkGroupSize
- urKernelGetGroupInfo CompileMaxLinearWorkGroupSize
- urKernelGetSubGroupInfo CompileNumSubGroups
- urKernelRetain CheckReferenceCount
- urKernelRelease CheckReferenceCount
- urKernelSetArgMemObj InvalidEnumeration

kbenzie

Please address the CI failures

scripts/core/kernel.yml

test/conformance/kernel/urKernelRetain.cpp

test/conformance/kernel/urKernelGetGroupInfo.cpp

isaacault · 2024-12-11T13:16:17Z

Please address the CI failures

Some of these failures are due to the DPC++ version being used being 10 months old. This predates the max_work_group_size kernel property implementation causing compile failures.

kbenzie · 2024-12-11T13:20:53Z

Please address the CI failures

Some of these failures are due to the DPC++ version being used being 10 months old. This predates the max_work_group_size kernel property implementation causing compile failures.

Okay, I guess we either need to disable these tests & the building the congruent kernel programs or figure out how to make an up to date DPC++ work without that change.

aarongreig · 2024-12-11T16:38:30Z

test/conformance/kernel/urKernelGetInfo.cpp

+                                     sizeof(backend), &backend, nullptr));
+    if (backend == UR_PLATFORM_BACKEND_OPENCL ||
+        backend == UR_PLATFORM_BACKEND_LEVEL_ZERO) {
+        // Older intel drivers don't attach any default attributes and newer ones force walk order to X/Y/Z using special attribute.


never noticed that clang-format doesn't touch comments like this, would prefer if it was manually formatted to maintain the < 80 per line

Suggested change

// Older intel drivers don't attach any default attributes and newer ones force walk order to X/Y/Z using special attribute.

// Older intel drivers don't attach any default attributes and newer

// ones force walk order to X/Y/Z using special attribute.

test/conformance/kernel/urKernelGetInfo.cpp

nrspruit

LGTM for L0

* Separate parameterized tests. Progresses oneapi-src#2290. * urKernelGetGroupInfo CompileWorkGroupSize test modified to use distinct dimensions. * urKernelSetArgPointer no longer returns invalid argument size. * Testcases added: * urKernelGetGroupInfo CompileMaxWorkGroupSize * urKernelGetGroupInfo CompileMaxLinearWorkGroupSize * urKernelGetSubGroupInfo CompileNumSubGroups * urKernelRetain CheckReferenceCount * urKernelRelease CheckReferenceCount * urKernelSetArgMemObj InvalidEnumeration

- Generate source. - Address inaccurate comments. - Remove unnecessary scope block.

- Remove SetUp override for test.

- Format comment to width 80.

isaacault · 2025-01-08T03:34:13Z

Match files updated for CI. Issues #2528 and #2529 opened to track the related match file additions.

isaacault · 2025-01-08T11:24:40Z

DPC++ PR for CI: intel/llvm#16555

PR for CI purposes. UR PR: oneapi-src/unified-runtime#2444 --------- Co-authored-by: Kenneth Benzie (Benie) <[email protected]>

isaacault requested a review from a team as a code owner December 10, 2024 16:20

github-actions bot added conformance Conformance test suite issues. specification Changes or additions to the specification labels Dec 10, 2024

kbenzie reviewed Dec 11, 2024

View reviewed changes

scripts/core/kernel.yml Show resolved Hide resolved

test/conformance/kernel/urKernelRetain.cpp Outdated Show resolved Hide resolved

aarongreig reviewed Dec 11, 2024

View reviewed changes

test/conformance/kernel/urKernelGetGroupInfo.cpp Outdated Show resolved Hide resolved

test/conformance/kernel/urKernelGetGroupInfo.cpp Outdated Show resolved Hide resolved

github-actions bot added the loader Loader related feature/bug label Dec 11, 2024

aarongreig reviewed Dec 11, 2024

View reviewed changes

aarongreig approved these changes Dec 11, 2024

View reviewed changes

isaacault force-pushed the kernel-cts branch from be7c240 to ee3046b Compare December 13, 2024 13:12

isaacault requested a review from a team as a code owner December 13, 2024 14:03

github-actions bot added the level-zero L0 adapter specific issues label Dec 13, 2024

martygrant reviewed Dec 13, 2024

View reviewed changes

test/conformance/kernel/urKernelGetInfo.cpp Show resolved Hide resolved

This was referenced Dec 13, 2024

Assert unsupported result for urKernelGetInfo and urUSMGetMemAllocInfo #2465

Closed

Assert unsupported result for urKernelGetInfo and urUSMGetMemAllocInfo #2466

Closed

nrspruit approved these changes Dec 14, 2024

View reviewed changes

isaacault force-pushed the kernel-cts branch from b59501e to c62de13 Compare December 16, 2024 15:18

martygrant mentioned this pull request Dec 19, 2024

Restructure GetInfo CTS tests to use separate tests instead of a switch #2290

Open

14 tasks

isaacault force-pushed the kernel-cts branch 4 times, most recently from f06fa29 to 21109bc Compare January 7, 2025 22:31

isaacault added 7 commits January 8, 2025 13:22

Tidy

00b180a

- Generate source. - Address inaccurate comments. - Remove unnecessary scope block.

Address Feedback:

f641907

- Remove SetUp override for test.

Feedback:

716882a

- Format comment to width 80.

Enqueue test data to match device_code.

9f85a1c

[L0] Return sizeof(size_t) bytes of data.

89621a0

Return sizeof(size_t) bytes of data, as per spec

2bdf669

isaacault added 6 commits January 8, 2025 13:22

Print out build error.

3cba7b2

Update match files.

347ee8c

Fix formatting.

918d3dc

Level Zero V2 return size_t bytes to match spec.

927e84f

Update match files for failing kernels.

ed6cc9d

Isolate fixed sub-group kernel for CTS.

568ac3f

isaacault force-pushed the kernel-cts branch from 21109bc to 568ac3f Compare January 8, 2025 03:22

This was referenced Jan 8, 2025

OpenCL CTS Unsupported SPIR-V module Compilation Failure #2528

Open

Level Zero Unsupported Feature Failed Build #2529

Open

isaacault mentioned this pull request Jan 8, 2025

[UR] Improve Kernel CTS intel/llvm#16555

Merged

kbenzie approved these changes Jan 8, 2025

View reviewed changes

kbenzie added the ready to merge Added to PR's which are ready to merge label Jan 8, 2025

Merge branch 'main' into kernel-cts

9c2b040

isaacault merged commit 1918293 into oneapi-src:main Jan 8, 2025
69 checks passed

martygrant pushed a commit to intel/llvm that referenced this pull request Jan 9, 2025

[UR] Improve Kernel CTS (#16555)

93de8f1

PR for CI purposes. UR PR: oneapi-src/unified-runtime#2444 --------- Co-authored-by: Kenneth Benzie (Benie) <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align Kernel CTS and Specification. #2444

Align Kernel CTS and Specification. #2444

isaacault commented Dec 10, 2024

kbenzie left a comment

isaacault commented Dec 11, 2024

kbenzie commented Dec 11, 2024

aarongreig Dec 11, 2024

nrspruit left a comment

isaacault commented Jan 8, 2025

isaacault commented Jan 8, 2025

	// Older intel drivers don't attach any default attributes and newer ones force walk order to X/Y/Z using special attribute.
	// Older intel drivers don't attach any default attributes and newer
	// ones force walk order to X/Y/Z using special attribute.

Align Kernel CTS and Specification. #2444

Align Kernel CTS and Specification. #2444

Conversation

isaacault commented Dec 10, 2024

kbenzie left a comment

Choose a reason for hiding this comment

isaacault commented Dec 11, 2024

kbenzie commented Dec 11, 2024

aarongreig Dec 11, 2024

Choose a reason for hiding this comment

nrspruit left a comment

Choose a reason for hiding this comment

isaacault commented Jan 8, 2025

isaacault commented Jan 8, 2025