Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of issues from the latest coverity scan. #2352

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix a number of issues from the latest coverity scan. #2352

merged 1 commit into from
Dec 6, 2024

Conversation

aarongreig
Copy link
Contributor

No description provided.

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. cuda CUDA adapter specific issues native-cpu Native CPU adapter specific issues sanitizer Sanitizer layer issues/changes/specification labels Nov 19, 2024
@aarongreig aarongreig force-pushed the aaron/fixCoverity15-11 branch 4 times, most recently from 3fb40a9 to e3261ff Compare November 20, 2024 15:11
@github-actions github-actions bot added level-zero L0 adapter specific issues hip HIP adapter specific issues labels Nov 20, 2024
@aarongreig aarongreig marked this pull request as ready for review November 21, 2024 13:39
@aarongreig aarongreig requested review from a team as code owners November 21, 2024 13:39
PietroGhg
PietroGhg approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

frasercrmck
frasercrmck reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA/HIP LGTM other than a nit about that comment

@aarongreig aarongreig force-pushed the aaron/fixCoverity15-11 branch from e3261ff to a284d1f Compare November 22, 2024 09:54
@github-actions github-actions bot added the opencl OpenCL adapter specific issues label Nov 22, 2024
@aarongreig aarongreig force-pushed the aaron/fixCoverity15-11 branch from a284d1f to a059ab9 Compare November 22, 2024 11:31
@aarongreig
Copy link
Contributor Author

LLVM PR intel/llvm#16158

@aarongreig aarongreig force-pushed the aaron/fixCoverity15-11 branch from a059ab9 to 21406b2 Compare November 25, 2024 10:41
@aarongreig
Copy link
Contributor Author

ping @oneapi-src/unified-runtime-level-zero-write

@aarongreig aarongreig force-pushed the aaron/fixCoverity15-11 branch from 21406b2 to 3d2b721 Compare November 26, 2024 17:26
@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Nov 29, 2024
@kbenzie kbenzie added the v0.11.x Include in the v0.11.x release label Dec 2, 2024
@martygrant martygrant merged commit aa72577 into oneapi-src:main Dec 6, 2024
73 of 76 checks passed
martygrant added a commit to aarongreig/intel-llvm that referenced this pull request Dec 6, 2024
@martygrant
[UR] Update tag to aa72577 for oneapi-src/unified-runtime#2352.
5eaaa80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frasercrmck frasercrmck frasercrmck left review comments

@kbenzie kbenzie kbenzie approved these changes

@pbalcer pbalcer pbalcer left review comments

@nrspruit nrspruit nrspruit approved these changes

@omarahmed1111 omarahmed1111 omarahmed1111 approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

Assignees
No one assigned
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge sanitizer Sanitizer layer issues/changes/specification v0.11.x Include in the v0.11.x release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aarongreig @frasercrmck @kbenzie @nrspruit @pbalcer @omarahmed1111 @PietroGhg @martygrant